]> xenbits.xensource.com Git - libvirt.git/commitdiff
openvz_driver: use g_autofree instead of VIR_FREE()
authorKarim Taha <kariem.taha2.7@gmail.com>
Sun, 17 Mar 2024 15:19:20 +0000 (17:19 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Tue, 19 Mar 2024 12:31:25 +0000 (13:31 +0100)
Signed-off-by: Karim Taha <kariem.taha2.7@gmail.com>
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/openvz/openvz_driver.c

index 1bd96dfb5604563ef80231e4a6263f8fe70982cd..19bdfa37f23406a6f5e351985069e1eea6fdc64c 100644 (file)
@@ -615,7 +615,7 @@ openvzGenerateVethName(int veid, char *dev_name_ve)
 static char *
 openvzGenerateContainerVethName(int veid)
 {
-    char *temp = NULL;
+    g_autofree char *temp = NULL;
     char *name = NULL;
 
     /* try to get line "^NETIF=..." from config */
@@ -638,8 +638,6 @@ openvzGenerateContainerVethName(int veid)
         name = g_strdup_printf("eth%d", max + 1);
     }
 
-    VIR_FREE(temp);
-
     return name;
 }
 
@@ -750,7 +748,6 @@ openvzDomainSetNetworkConfig(virConnectPtr conn,
 {
     size_t i;
     g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER;
-    char *param;
     int first = 1;
     struct openvz_driver *driver =  conn->privateData;
 
@@ -771,15 +768,15 @@ openvzDomainSetNetworkConfig(virConnectPtr conn,
     }
 
     if (driver->version < VZCTL_BRIDGE_MIN_VERSION && def->nnets) {
+        g_autofree char *param = NULL;
+
         param = virBufferContentAndReset(&buf);
         if (param) {
             if (openvzWriteVPSConfigParam(strtoI(def->name), "NETIF", param) < 0) {
-                VIR_FREE(param);
                 virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                                _("cannot replace NETIF config"));
                 return -1;
             }
-            VIR_FREE(param);
         }
     }
 
@@ -1075,7 +1072,7 @@ openvzDomainGetAutostart(virDomainPtr dom, int *autostart)
 {
     struct openvz_driver *driver = dom->conn->privateData;
     virDomainObj *vm;
-    char *value = NULL;
+    g_autofree char *value = NULL;
     int ret = -1;
 
     if (!(vm = openvzDomObjFromDomain(driver, dom->uuid)))
@@ -1093,8 +1090,6 @@ openvzDomainGetAutostart(virDomainPtr dom, int *autostart)
     ret = 0;
 
  cleanup:
-    VIR_FREE(value);
-
     virDomainObjEndAPI(&vm);
     return ret;
 }
@@ -1405,7 +1400,7 @@ static int openvzConnectListDefinedDomains(virConnectPtr conn G_GNUC_UNUSED,
 static int openvzGetProcessInfo(unsigned long long *cpuTime, int vpsid)
 {
     FILE *fp;
-    char *line = NULL;
+    g_autofree char *line = NULL;
     size_t line_size = 0;
     unsigned long long usertime, systime, nicetime;
     int readvps = vpsid + 1;  /* ensure readvps is initially different */
@@ -1442,7 +1437,6 @@ Version: 2.2
         }
     }
 
-    VIR_FREE(line);
     VIR_FORCE_FCLOSE(fp);
     if (err)
         return -1;