]> xenbits.xensource.com Git - libvirt.git/commitdiff
tests: Add return value check in checkUserInfo
authorJohn Ferlan <jferlan@redhat.com>
Sun, 3 Nov 2019 12:39:22 +0000 (07:39 -0500)
committerJohn Ferlan <jferlan@redhat.com>
Wed, 6 Nov 2019 16:27:12 +0000 (11:27 -0500)
Commit 1c8113f9c added the call to virTypedParamsGetString without
a return value check which caused Coverity to complain especially
since other checks for the same function are made.

Found by Coverity

Signed-off-by: John Ferlan <jferlan@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
tests/qemuagenttest.c

index cef9ae5fee14732205857902b74e0262e74e2a5d..ae55086d17d27a8a631aa16db85f89da9068563d 100644 (file)
@@ -1127,7 +1127,9 @@ checkUserInfo(virTypedParameterPtr params,
 
     snprintf(param_name, VIR_TYPED_PARAM_FIELD_LENGTH,
              "user.%zu.domain", nth);
-    virTypedParamsGetString(params, nparams, param_name, &domain);
+    if (virTypedParamsGetString(params, nparams, param_name, &domain) < 0)
+        return -1;
+
     if (STRNEQ_NULLABLE(expDomain, domain)) {
         virReportError(VIR_ERR_INTERNAL_ERROR,
                        "Expected domain '%s', got '%s'",