]> xenbits.xensource.com Git - libvirt.git/commitdiff
virsh: use g_strdup in virshDomainGetEditMetadata
authorJán Tomko <jtomko@redhat.com>
Fri, 18 Oct 2019 15:24:29 +0000 (17:24 +0200)
committerJán Tomko <jtomko@redhat.com>
Sun, 20 Oct 2019 12:37:16 +0000 (14:37 +0200)
Prefer GLib's g_strdup to vshStrdup.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
tools/virsh-domain.c

index 3ba84514706a45b2202a7745a26e2f6762eea724..715ad51ef5975d19db88cc8f34674ba3a0bcd0d5 100644 (file)
@@ -8523,7 +8523,7 @@ static const vshCmdOptDef opts_metadata[] = {
 
 /* helper to add new metadata using the --edit option */
 static char *
-virshDomainGetEditMetadata(vshControl *ctl,
+virshDomainGetEditMetadata(vshControl *ctl G_GNUC_UNUSED,
                            virDomainPtr dom,
                            const char *uri,
                            unsigned int flags)
@@ -8533,7 +8533,7 @@ virshDomainGetEditMetadata(vshControl *ctl,
     if (!(ret = virDomainGetMetadata(dom, VIR_DOMAIN_METADATA_ELEMENT,
                                      uri, flags))) {
         vshResetLibvirtError();
-        ret = vshStrdup(ctl, "\n");
+        ret = g_strdup("\n");
     }
 
     return ret;