]> xenbits.xensource.com Git - people/liuw/libxenctrl-split/libvirt.git/commitdiff
qemu: fix memleak in virCapabilitiesDomainDataLookup
authorZhang Bo <oscar.zhangbo@huawei.com>
Mon, 27 Apr 2015 06:41:43 +0000 (14:41 +0800)
committerJán Tomko <jtomko@redhat.com>
Mon, 27 Apr 2015 08:04:38 +0000 (10:04 +0200)
virBufferContentAndReset() doesn't free buf contents, we should use
virBufferFreeAndReset() to get buf freed.

Signed-off-by: Zhang Bo <oscar.zhangbo@huawei.com>
src/conf/capabilities.c

index 2c674a8a7044b3d9b257df25f1ff22c8b2f8b375..922741fe256768083651e7e3af0b60bbf3d5ae75 100644 (file)
@@ -701,13 +701,14 @@ virCapabilitiesDomainDataLookup(virCapsPtr caps,
             !virBufferCurrentContent(&buf)[0])
             virBufferAsprintf(&buf, "%s", _("any configuration"));
         if (virBufferCheckError(&buf) < 0) {
-            virBufferContentAndReset(&buf);
+            virBufferFreeAndReset(&buf);
             goto error;
         }
 
         virReportError(VIR_ERR_INVALID_ARG,
                        _("could not find capabilities for %s"),
-                       virBufferContentAndReset(&buf));
+                       virBufferCurrentContent(&buf));
+        virBufferFreeAndReset(&buf);
         goto error;
     }