NetworkPkg: Dhcp6Dxe: Packet-Length is not updated before appending

In order for Dhcp6AppendIaAddrOption (..) to safely append the IA
Address option, the Packet-Length field must be updated before appending
the option.

Cc: Saloni Kasbekar <saloni.kasbekar@intel.com>
Cc: Zachary Clark-williams <zachary.clark-williams@intel.com>
Signed-off-by: Doug Flick [MSFT] <doug.edk2@gmail.com>
Reviewed-by: Saloni Kasbekar <saloni.kasbekar@intel.com>
Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>

diff --git a/NetworkPkg/Dhcp6Dxe/Dhcp6Utility.c b/NetworkPkg/Dhcp6Dxe/Dhcp6Utility.c
index e4e072562296ffbe2a753027676b98182e40d5fa..f38e3ee3fe1a0cc01e377eb2f20c1d54e4f5ced0 100644 (file)
--- a/NetworkPkg/Dhcp6Dxe/Dhcp6Utility.c
+++ b/NetworkPkg/Dhcp6Dxe/Dhcp6Utility.c
@@ -924,6 +924,11 @@ Dhcp6AppendIaOption (
     *PacketCursor += sizeof (T2);\r
   }\r
 \r
+  //\r
+  // Update the packet length\r
+  //\r
+  Packet->Length += BytesNeeded;\r
+\r
   //\r
   // Fill all the addresses belong to the Ia\r
   //\r
@@ -935,11 +940,6 @@ Dhcp6AppendIaOption (
     }\r
   }\r
 \r
-  //\r
-  // Update the packet length\r
-  //\r
-  Packet->Length += BytesNeeded;\r
-\r
   //\r
   // Fill the value of Ia option length\r
   //\r