]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu_validate: Validate net backends against QEMU caps
authorMichal Privoznik <mprivozn@redhat.com>
Thu, 27 Jun 2024 12:09:52 +0000 (14:09 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Mon, 1 Jul 2024 10:33:14 +0000 (12:33 +0200)
Now that we have a capability for each domain net backend we can
start validating user's selection against QEMU capabilities.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
src/qemu/qemu_validate.c

index b392428f48d9ac5ea93c0b373b5b6b27d87b495b..23d642c1cefc81cb9a67e7147f3a0e0b59bb46d6 100644 (file)
@@ -1705,11 +1705,27 @@ qemuValidateDomainDeviceDefNetwork(const virDomainNetDef *net,
     size_t i;
 
     if (net->type == VIR_DOMAIN_NET_TYPE_USER) {
-        if (net->backend.type == VIR_DOMAIN_NET_BACKEND_PASST &&
-            !virQEMUCapsGet(qemuCaps, QEMU_CAPS_NETDEV_STREAM)) {
-            virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
-                           _("the passt network backend is not supported with this QEMU binary"));
-            return -1;
+        switch (net->backend.type) {
+        case VIR_DOMAIN_NET_BACKEND_DEFAULT:
+            if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_NETDEV_USER)) {
+                virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
+                               _("the '%1$s' network backend is not supported with this QEMU binary"),
+                               virDomainNetBackendTypeToString(net->backend.type));
+                return -1;
+            }
+            break;
+
+        case VIR_DOMAIN_NET_BACKEND_PASST:
+            if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_NETDEV_STREAM)) {
+                virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
+                               _("the '%1$s' network backend is not supported with this QEMU binary"),
+                               virDomainNetBackendTypeToString(net->backend.type));
+                return -1;
+            }
+            break;
+
+        case VIR_DOMAIN_NET_BACKEND_LAST:
+            break;
         }
         if (net->guestIP.nroutes) {
             virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",