]> xenbits.xensource.com Git - libvirt.git/commitdiff
conf: use virXMLFormatElement for <iommu>
authorJán Tomko <jtomko@redhat.com>
Tue, 29 Aug 2017 16:37:39 +0000 (18:37 +0200)
committerJán Tomko <jtomko@redhat.com>
Mon, 11 Sep 2017 07:45:34 +0000 (09:45 +0200)
Simplify the formatting function even further.

src/conf/domain_conf.c

index 590d90e0a0b52f3bae94efcab9bff28c232ab1a8..ae2e96e96432b4d8a3ec4788344d7314c6c55bb9 100644 (file)
@@ -25073,6 +25073,7 @@ virDomainIOMMUDefFormat(virBufferPtr buf,
                         const virDomainIOMMUDef *iommu)
 {
     virBuffer childBuf = VIR_BUFFER_INITIALIZER;
+    virBuffer attrBuf = VIR_BUFFER_INITIALIZER;
     virBuffer driverAttrBuf = VIR_BUFFER_INITIALIZER;
     int ret = -1;
 
@@ -25098,16 +25099,11 @@ virDomainIOMMUDefFormat(virBufferPtr buf,
     if (virXMLFormatElement(&childBuf, "driver", &driverAttrBuf, NULL) < 0)
         goto cleanup;
 
-    virBufferAsprintf(buf, "<iommu model='%s'",
+    virBufferAsprintf(&attrBuf, " model='%s'",
                       virDomainIOMMUModelTypeToString(iommu->model));
 
-    if (virBufferError(&childBuf) != 0 || virBufferUse(&childBuf)) {
-        virBufferAddLit(buf, ">\n");
-        virBufferAddBuffer(buf, &childBuf);
-        virBufferAddLit(buf, "</iommu>\n");
-    } else {
-        virBufferAddLit(buf, "/>\n");
-    }
+    if (virXMLFormatElement(buf, "iommu", &attrBuf, &childBuf) < 0)
+        goto cleanup;
 
     ret = 0;