]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: block: Remove unused qemuBlockStorageSourceDetachOneBlockdev
authorPeter Krempa <pkrempa@redhat.com>
Tue, 14 Nov 2023 16:09:03 +0000 (17:09 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Mon, 27 Nov 2023 09:14:20 +0000 (10:14 +0100)
The only caller was converted to use the common blockdev infrastructure
thus this function is no longer needed.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_block.c
src/qemu/qemu_block.h

index 8b73d93962b131d7db7117260f7d473abf459ed5..7e9daf0bdc2720ff812568a0980cc79680223cb5 100644 (file)
@@ -1942,40 +1942,6 @@ qemuBlockStorageSourceChainDetach(qemuMonitor *mon,
 }
 
 
-/**
- * qemuBlockStorageSourceDetachOneBlockdev:
- * @driver: qemu driver object
- * @vm: domain object
- * @asyncJob: currently running async job
- * @src: storage source to detach
- *
- * Detaches one virStorageSource using blockdev-del. Note that this does not
- * detach any authentication/encryption objects. This function enters the
- * monitor internally.
- */
-int
-qemuBlockStorageSourceDetachOneBlockdev(virDomainObj *vm,
-                                        virDomainAsyncJob asyncJob,
-                                        virStorageSource *src)
-{
-    int ret;
-
-    if (qemuDomainObjEnterMonitorAsync(vm, asyncJob) < 0)
-        return -1;
-
-    ret = qemuMonitorBlockdevDel(qemuDomainGetMonitor(vm),
-                                 qemuBlockStorageSourceGetFormatNodename(src));
-
-    if (ret == 0)
-        ret = qemuMonitorBlockdevDel(qemuDomainGetMonitor(vm),
-                                     qemuBlockStorageSourceGetStorageNodename(src));
-
-    qemuDomainObjExitMonitor(vm);
-
-    return ret;
-}
-
-
 int
 qemuBlockSnapshotAddBlockdev(virJSONValue *actions,
                              virDomainDiskDef *disk,
index f37e10216c8fd597f200cfa375a9fbe0321fba05..0eab0d822c1101ae825cede608f551ae0fa01c0c 100644 (file)
@@ -149,11 +149,6 @@ void
 qemuBlockStorageSourceAttachRollback(qemuMonitor *mon,
                                      qemuBlockStorageSourceAttachData *data);
 
-int
-qemuBlockStorageSourceDetachOneBlockdev(virDomainObj *vm,
-                                        virDomainAsyncJob asyncJob,
-                                        virStorageSource *src);
-
 struct _qemuBlockStorageSourceChainData {
     qemuBlockStorageSourceAttachData **srcdata;
     size_t nsrcdata;