]> xenbits.xensource.com Git - people/aperard/xen-unstable.git/commitdiff
x86/setup: remove bootstrap_map_addr() usage of destroy_xen_mappings()
authorRoger Pau Monné <roger.pau@ctrix.com>
Thu, 14 Nov 2024 15:12:51 +0000 (16:12 +0100)
committerJan Beulich <jbeulich@suse.com>
Thu, 14 Nov 2024 15:12:51 +0000 (16:12 +0100)
bootstrap_map_addr() needs to be careful to not remove existing page-table
structures when tearing down mappings, as such pagetable structures might be
needed to fulfill subsequent mappings requests.  The comment ahead of the
function already notes that pagetable memory shouldn't be allocated.

Fix this by using map_pages_to_xen(), which does zap the page-table entries,
but does not free page-table structures even when empty.

Fixes: 4376c05c3113 ('x86-64: use 1GB pages in 1:1 mapping if available')
Signed-off-by: Roger Pau Monné <roger.pau@ctrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
xen/arch/x86/setup.c

index 4feef9f2e05ab418266ae0968e5651cbc1a291ad..5da1c6a34519b3e6f1b319a8563ba4b8c2f962f4 100644 (file)
@@ -462,7 +462,9 @@ static void *__init bootstrap_map_addr(paddr_t start, paddr_t end)
 
     if ( !end )
     {
-        destroy_xen_mappings(BOOTSTRAP_MAP_BASE, BOOTSTRAP_MAP_LIMIT);
+        map_pages_to_xen(BOOTSTRAP_MAP_BASE, INVALID_MFN,
+                         PFN_DOWN(map_cur - BOOTSTRAP_MAP_BASE),
+                         _PAGE_NONE);
         map_cur = BOOTSTRAP_MAP_BASE;
         return NULL;
     }