]> xenbits.xensource.com Git - libvirt.git/commitdiff
build: Drop execute permissions on virsh bash completion command
authorJim Fehlig <jfehlig@suse.com>
Thu, 30 Jan 2020 18:29:41 +0000 (11:29 -0700)
committerJim Fehlig <jfehlig@suse.com>
Fri, 31 Jan 2020 15:49:04 +0000 (08:49 -0700)
rpmlint complains about "script-without-shebang" due to the execute
permissions on /usr/share/bash-completion/completions/vsh. Use
INSTALL_DATA instead of INSTALL_SCRIPT to avoid the unnecessary
execute permissions.

Signed-off-by: Jim Fehlig <jfehlig@suse.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
tools/Makefile.am

index 426a6ba6610a1455c2de3ef724a2d6a311ad4ee0..d9d1a2f43f62a066102fa852327e344aef3e8594 100644 (file)
@@ -357,7 +357,7 @@ libvirt-guests.service: libvirt-guests.service.in $(top_builddir)/config.status
 if WITH_BASH_COMPLETION
 install-bash-completion:
        $(MKDIR_P) "$(DESTDIR)$(BASH_COMPLETIONS_DIR)"
-       $(INSTALL_SCRIPT) $(srcdir)/bash-completion/vsh \
+       $(INSTALL_DATA) $(srcdir)/bash-completion/vsh \
                "$(DESTDIR)$(BASH_COMPLETIONS_DIR)/vsh"
        ( cd $(DESTDIR)$(BASH_COMPLETIONS_DIR) && \
                rm -f virsh virt-admin && \