]> xenbits.xensource.com Git - people/aperard/ovmf.git/commitdiff
NetworkPkg/WifiConnectionManagerDxe: Fix Connection Manager HII errors
authorNeo Hsueh <Hong-Chih.Hsueh@amd.com>
Thu, 1 Aug 2024 19:11:57 +0000 (14:11 -0500)
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Tue, 3 Sep 2024 06:24:43 +0000 (06:24 +0000)
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4824

Fix the wrong logic in WifiMgrDxeHiiConfigAccessCallback with
EFI_BROWSER_ACTION_CHANGING action.

Cc: Jiangang He <jiangang.he@amd.com>
Cc: Abner Chang <abner.chang@amd.com>
Signed-off-by: Neo Hsueh <Hong-Chih.Hsueh@amd.com>
NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrHiiConfigAccess.c

index f242bdf0569d6dff4300368a72acb1b799404920..00804e546750098411f30c5061357d6de50311e9 100644 (file)
@@ -1490,6 +1490,7 @@ WifiMgrDxeHiiConfigAccessCallback (
   } else if (Action == EFI_BROWSER_ACTION_FORM_CLOSE) {\r
     switch (QuestionId) {\r
       case KEY_EAP_ENROLL_CERT_FROM_FILE:\r
+      case KEY_REFRESH_NETWORK_LIST:\r
 \r
         if (Private->CurrentNic->UserSelectedProfile == NULL) {\r
           break;\r
@@ -1911,39 +1912,6 @@ WifiMgrDxeHiiConfigAccessCallback (
               NULL\r
               );\r
           }\r
-\r
-          if (Private->CurrentNic->UserSelectedProfile == NULL) {\r
-            break;\r
-          }\r
-\r
-          Profile = Private->CurrentNic->UserSelectedProfile;\r
-\r
-          //\r
-          // Enter the network connection configuration page\r
-          // Recovery from restored data\r
-          //\r
-          if (HiiSetString (Private->RegisteredHandle, STRING_TOKEN (STR_SSID), Profile->SSId, NULL) == 0) {\r
-            return EFI_OUT_OF_RESOURCES;\r
-          }\r
-\r
-          IfrNvData->SecurityType = Profile->SecurityType;\r
-          if (HiiSetString (\r
-                Private->RegisteredHandle,\r
-                STRING_TOKEN (STR_SECURITY_TYPE),\r
-                mSecurityType[IfrNvData->SecurityType],\r
-                NULL\r
-                ) == 0)\r
-          {\r
-            return EFI_OUT_OF_RESOURCES;\r
-          }\r
-\r
-          if (  (IfrNvData->SecurityType == SECURITY_TYPE_WPA2_ENTERPRISE)\r
-             || (IfrNvData->SecurityType == SECURITY_TYPE_WPA3_ENTERPRISE))\r
-          {\r
-            IfrNvData->EapAuthMethod       = Profile->EapAuthMethod;\r
-            IfrNvData->EapSecondAuthMethod = Profile->EapSecondAuthMethod;\r
-            StrCpyS (IfrNvData->EapIdentity, EAP_IDENTITY_SIZE, Profile->EapIdentity);\r
-          }\r
         }\r
 \r
         break;\r