]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: Fix off-by-one error in block I/O throttle messages
authorMartin Kletzander <mkletzan@redhat.com>
Mon, 25 Apr 2016 09:54:56 +0000 (11:54 +0200)
committerMartin Kletzander <mkletzan@redhat.com>
Mon, 25 Apr 2016 10:16:38 +0000 (12:16 +0200)
QEMU_BLOCK_IOTUNE_MAX is the maximum inclusively, so let's modify the
message so it makes sense.

https://bugzilla.redhat.com/show_bug.cgi?id=1329041

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
src/qemu/qemu_command.c
src/qemu/qemu_driver.c

index ef4a62dafb5b936e2f88260e065de111ded66838..9597b307e9de495ea6938a089b8d86dc9debf8c0 100644 (file)
@@ -1409,7 +1409,7 @@ qemuBuildDriveStr(virConnectPtr conn,
         disk->blkdeviotune.size_iops_sec > QEMU_BLOCK_IOTUNE_MAX) {
         virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED,
                       _("block I/O throttle limit must "
-                        "be less than %llu using QEMU"), QEMU_BLOCK_IOTUNE_MAX);
+                        "be no more than %llu using QEMU"), QEMU_BLOCK_IOTUNE_MAX);
         goto error;
     }
 
index 90f541cf6d749bfa658bd448d63a6e21734ff2b8..91ed0fa4595a3a1ca443ee89d4854989794d31c4 100644 (file)
@@ -17529,7 +17529,7 @@ qemuDomainSetBlockIoTune(virDomainPtr dom,
         if (param->value.ul > QEMU_BLOCK_IOTUNE_MAX) {
             virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED,
                            _("block I/O throttle limit value must"
-                             " be less than %llu"), QEMU_BLOCK_IOTUNE_MAX);
+                             " be no more than %llu"), QEMU_BLOCK_IOTUNE_MAX);
             goto endjob;
         }