Always reset PCI devices

diff --git a/ChangeLog b/ChangeLog
index c7298fdd33b351e96d0ea2ddecc10bbb0091b4c0..b104c22bc38107d0db32b40c11e4a0dafc77a477 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+Mon Mar 2 20:21:00 GMT 2009 Daniel P. Berrange <berrange@redhat.com>
+
+       * src/qemu_conf.c: Always reset PCI devices before starting guests.
+       Add todo item for non-managed PCI devs
+
 Mon Mar 2 20:18:00 GMT 2009 Daniel P. Berrange <berrange@redhat.com>
 
        * src/libvirt_private.syms: Export virUnrefConnect and

diff --git a/src/qemu_conf.c b/src/qemu_conf.c
index fad3eeb622c8946005f4714dde83600526be387d..d7257fa0dfa0a97b2b71cfbbc59c3ab315dca04e 100644 (file)
--- a/src/qemu_conf.c
+++ b/src/qemu_conf.c
@@ -1411,7 +1411,11 @@ int qemudBuildCommandLine(virConnectPtr conn,
                 }
 
                 pciFreeDevice(conn, dev);
-            }
+            } /* else {
+                XXX validate that non-managed device isn't in use, eg
+                by checking that device is either un-bound, or bound
+                to pci-stub.ko
+            } */
         }
 
     }
@@ -1421,8 +1425,7 @@ int qemudBuildCommandLine(virConnectPtr conn,
         virDomainHostdevDefPtr hostdev = vm->def->hostdevs[i];
         pciDevice *dev;
 
-        if (!hostdev->managed ||
-            hostdev->mode != VIR_DOMAIN_HOSTDEV_MODE_SUBSYS ||
+        if (hostdev->mode != VIR_DOMAIN_HOSTDEV_MODE_SUBSYS ||
             hostdev->source.subsys.type != VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI)
             continue;