]> xenbits.xensource.com Git - libvirt.git/commitdiff
syntax-check: forbid usage of snprintf
authorPavel Hrdina <phrdina@redhat.com>
Wed, 13 Nov 2019 16:33:27 +0000 (17:33 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Wed, 20 Nov 2019 12:30:34 +0000 (13:30 +0100)
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
build-aux/syntax-check.mk

index 6b62e20ed43605dd56c861d8bc8d5afd653f92a5..f1e976ec769712dcd5ccd3c20fc3ce0e1abea3e1 100644 (file)
@@ -482,6 +482,11 @@ sc_prohibit_sprintf:
        halt='use g_snprintf, not sprintf' \
          $(_sc_search_regexp)
 
+sc_prohibit_snprintf:
+       @prohibit='\<snprintf\>' \
+       halt='use g_snprintf, not snprintf' \
+         $(_sc_search_regexp)
+
 sc_prohibit_readlink:
        @prohibit='\<readlink *\(' \
        halt='use virFileResolveLink, not readlink' \
@@ -2277,6 +2282,9 @@ exclude_file_name_regexp--sc_prohibit_setuid = ^src/util/virutil\.c|tools/virt-l
 exclude_file_name_regexp--sc_prohibit_sprintf = \
   ^(build-aux/syntax-check\.mk|docs/hacking\.html\.in|.*\.stp|.*\.pl)$$
 
+exclude_file_name_regexp--sc_prohibit_snprintf = \
+  ^(build-aux/syntax-check\.mk|docs/hacking\.html\.in|tools/virt-login-shell\.c)$$
+
 exclude_file_name_regexp--sc_prohibit_strncpy = ^src/util/virstring\.c$$
 
 exclude_file_name_regexp--sc_prohibit_strtol = ^examples/.*$$