]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: snapshot: Terminate job when memory compression program isn't found
authorPeter Krempa <pkrempa@redhat.com>
Wed, 14 May 2014 07:43:52 +0000 (09:43 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Wed, 14 May 2014 07:43:52 +0000 (09:43 +0200)
If the compression program for external snapshot memory image isn't
found we exitted the function without terminating the domain job. This
caused the domain to be unusable.

The problem was introduced in commit 7df5093f.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1097503

src/qemu/qemu_driver.c

index a5c7f4fb757c288fbfa22dc1be48bbe38130c484..52ca47c33eac448d08ad469d6e0901ee89b6a201 100644 (file)
@@ -13207,13 +13207,14 @@ qemuDomainSnapshotCreateActiveExternal(virConnectPtr conn,
                 virReportError(VIR_ERR_OPERATION_FAILED, "%s",
                                _("Invalid snapshot image format specified "
                                  "in configuration file"));
-                goto cleanup;
+                goto endjob;
             }
+
             if (!qemuCompressProgramAvailable(compressed)) {
                 virReportError(VIR_ERR_OPERATION_FAILED, "%s",
                                _("Compression program for image format "
                                  "in configuration file isn't available"));
-                goto cleanup;
+                goto endjob;
             }
         }