]> xenbits.xensource.com Git - xen.git/commitdiff
x86: Fix pirq teardown on domain destruction.
authorWei Gang <gang.wei@intel.com>
Wed, 26 Jan 2011 09:05:53 +0000 (09:05 +0000)
committerWei Gang <gang.wei@intel.com>
Wed, 26 Jan 2011 09:05:53 +0000 (09:05 +0000)
The privilege check in unmap_domain_pirq() fails since the teardown
completes in RCU (idle domain) context. We can remove the check since
it is covered in physdev_op() already, which is the only potentially
unprivileged caller.

Signed-off-by: Wei Gang <gang.wei@intel.com>
xen-unstable changeset:   22816:e7f44fb4ecc3
xen-unstable date:        Wed Jan 26 08:54:12 2011 +0000

xen/arch/x86/irq.c

index 5458cedaa3682068e4c3bfa3bfc324dd8e0bb261..e0c7c95957912496b6be2ad4491e9d0c330e295c 100644 (file)
@@ -1549,9 +1549,6 @@ int unmap_domain_pirq(struct domain *d, int pirq)
     if ( (pirq < 0) || (pirq >= d->nr_pirqs) )
         return -EINVAL;
 
-    if ( !IS_PRIV_FOR(current->domain, d) )
-        return -EINVAL;
-
     ASSERT(spin_is_locked(&pcidevs_lock));
     ASSERT(spin_is_locked(&d->event_lock));