]> xenbits.xensource.com Git - xen.git/commitdiff
x86/mce: clear MSR_IA32_MCG_STATUS by writing 0
authorHaozhong Zhang <haozhong.zhang@intel.com>
Wed, 8 Mar 2017 14:10:45 +0000 (15:10 +0100)
committerJan Beulich <jbeulich@suse.com>
Wed, 8 Mar 2017 14:10:45 +0000 (15:10 +0100)
On Intel CPU, an attemp to write to MSR_IA32_MCG_STATUS with any
non-zero value would result in #GP.

This commit writes 0 on AMD CPU as well instead of just clearing MCIP
bit, because all non-reserved bits of MSR_IA32_MCG_STATUS have been
handled at this point.

Signed-off-by: Haozhong Zhang <haozhong.zhang@intel.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
xen/arch/x86/cpu/mcheck/mce.c

index c4ffb27f60bd0f5f8fdfecc1ef85e571abd0c086..35117f8c8f2387382fd95a7e4f44badc26bd632b 100644 (file)
@@ -535,7 +535,7 @@ void mcheck_cmn_handler(const struct cpu_user_regs *regs)
     gstatus = mca_rdmsr(MSR_IA32_MCG_STATUS);
     if ((gstatus & MCG_STATUS_MCIP) != 0) {
         mce_printk(MCE_CRITICAL, "MCE: Clear MCIP@ last step");
-        mca_wrmsr(MSR_IA32_MCG_STATUS, gstatus & ~MCG_STATUS_MCIP);
+        mca_wrmsr(MSR_IA32_MCG_STATUS, 0);
     }
     mce_barrier_exit(&mce_trap_bar);