]> xenbits.xensource.com Git - libvirt.git/commitdiff
vbox: Drop @data and @name from UIHost::CreateHostOnlyNetworkInterface()
authorMichal Privoznik <mprivozn@redhat.com>
Sun, 22 Jan 2023 12:01:41 +0000 (13:01 +0100)
committerMichal Privoznik <mprivozn@redhat.com>
Tue, 24 Jan 2023 09:23:57 +0000 (10:23 +0100)
The @data and @name arguments of
UIHost::CreateHostOnlyNetworkInterface() callback are unused.
Drop them and also their propagation from parent functions.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
src/vbox/vbox_network.c
src/vbox/vbox_tmpl.c
src/vbox/vbox_uniformed_api.h

index c3dea6610231b39660eddb875fa81109c10c324f..f369e466ab82fc000f3423bab35a84351e3fff57 100644 (file)
@@ -429,8 +429,7 @@ vboxNetworkDefineCreateXML(virConnectPtr conn, const char *xml, bool start,
      * NULL. (We can't assign a new name to hostonly network, only
      * take the given name, say vboxnet0)
      */
-    gVBoxAPI.UIHost.CreateHostOnlyNetworkInterface(data, host, def->name,
-                                                   &networkInterface);
+    gVBoxAPI.UIHost.CreateHostOnlyNetworkInterface(host, &networkInterface);
 
     if (!networkInterface)
         goto cleanup;
index 7d3431208b530a67ae17b29a5be8f653a8f632e1..c570dd580210106288fe6f1a1aaa46efe4edf48a 100644 (file)
@@ -2004,8 +2004,7 @@ _hostFindHostNetworkInterfaceByName(IHost *host, PRUnichar *name,
 }
 
 static nsresult
-_hostCreateHostOnlyNetworkInterface(struct _vboxDriver *data G_GNUC_UNUSED,
-                                    IHost *host, char *name G_GNUC_UNUSED,
+_hostCreateHostOnlyNetworkInterface(IHost *host,
                                     IHostNetworkInterface **networkInterface)
 {
     nsresult rc = -1;
index b5a71a338c3489af6eebb9c5c98fe293ca9e18dc..3a9c317092fe5925eab756bf0f4118c000cf8634 100644 (file)
@@ -453,8 +453,7 @@ typedef struct {
                                              IHostNetworkInterface **networkInterface);
     nsresult (*FindHostNetworkInterfaceByName)(IHost *host, PRUnichar *name,
                                                IHostNetworkInterface **networkInterface);
-    nsresult (*CreateHostOnlyNetworkInterface)(struct _vboxDriver *driver,
-                                               IHost *host, char *name,
+    nsresult (*CreateHostOnlyNetworkInterface)(IHost *host,
                                                IHostNetworkInterface **networkInterface);
     nsresult (*RemoveHostOnlyNetworkInterface)(IHost *host, vboxIID *iid,
                                                IProgress **progress);