qemuhotplugtest: Make the test more useful by validating used commands against QMP...

qemuhotplugtest validates only that a given command is used but not the
arguments of the command. With this patch we'll validate the arguments
against the QMP schema thus we can catch possible issues with deprecated
commands.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>

diff --git a/tests/qemuhotplugtest.c b/tests/qemuhotplugtest.c
index 9c8407c5ef1e863dc715293558c66632e1d8a003..63a6833cfde72bbd44a4d5decf6c057bba59aaa8 100644 (file)
--- a/tests/qemuhotplugtest.c
+++ b/tests/qemuhotplugtest.c
@@ -57,6 +57,7 @@ struct qemuHotplugTestData {
     GHashTable *capsLatestFiles;
     GHashTable *capsCache;
     GHashTable *schemaCache;
+    GHashTable *schema;
 };
 
 static int
@@ -342,7 +343,7 @@ testQemuHotplug(const void *data)
         if (qemuHotplugCreateObjects(driver.xmlopt, &vm, domain_xml,
                                      test->arch, test->capsLatestFiles,
                                      test->capsCache, test->schemaCache,
-                                     NULL) < 0)
+                                     &test->schema) < 0)
             goto cleanup;
     }
 
@@ -356,7 +357,7 @@ testQemuHotplug(const void *data)
 
     /* Now is the best time to feed the spoofed monitor with predefined
      * replies. */
-    if (!(test_mon = qemuMonitorTestNew(driver.xmlopt, vm, NULL, NULL)))
+    if (!(test_mon = qemuMonitorTestNew(driver.xmlopt, vm, NULL, test->schema)))
         goto cleanup;
 
     tmp = test->mon;