]> xenbits.xensource.com Git - people/pauldu/qemu.git/commitdiff
hw/arm/virt: Fix devicetree warning about the SMMU node
authorJean-Philippe Brucker <jean-philippe@linaro.org>
Tue, 27 Sep 2022 10:03:47 +0000 (11:03 +0100)
committerPeter Maydell <peter.maydell@linaro.org>
Thu, 29 Sep 2022 16:55:06 +0000 (17:55 +0100)
The SMMUv3 node isn't expected to have clock properties
(unlike the SMMUv2). Fix the corresponding dt-validate warning:

  smmuv3@9050000: 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+'
  From schema: linux/Documentation/devicetree/bindings/iommu/arm,smmu-v3.yaml

Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
[PMM: tweaked commit message as suggested by Eric]
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Message-id: 20220927100347.176606-7-jean-philippe@linaro.org
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
hw/arm/virt.c

index b67ba0f2a10436dd271bf87840f7a8ec3630b335..cda9defe8f0900636c1846bc6f01cdc7c36d6b0f 100644 (file)
@@ -1361,8 +1361,6 @@ static void create_smmu(const VirtMachineState *vms,
     qemu_fdt_setprop(ms->fdt, node, "interrupt-names", irq_names,
                      sizeof(irq_names));
 
-    qemu_fdt_setprop_cell(ms->fdt, node, "clocks", vms->clock_phandle);
-    qemu_fdt_setprop_string(ms->fdt, node, "clock-names", "apb_pclk");
     qemu_fdt_setprop(ms->fdt, node, "dma-coherent", NULL, 0);
 
     qemu_fdt_setprop_cell(ms->fdt, node, "#iommu-cells", 1);