]> xenbits.xensource.com Git - people/dariof/xen.git/commitdiff
sched: don't disable interrupts all the time when dumping run-queues
authorJuergen Gross <jgross@suse.com>
Thu, 20 Feb 2020 10:38:31 +0000 (11:38 +0100)
committerJan Beulich <jbeulich@suse.com>
Thu, 20 Feb 2020 10:38:31 +0000 (11:38 +0100)
Having interrupts disabled all the time when running dump_runq() is
not necessary. All the called functions are doing proper locking
and disable interrupts if needed.

Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Dario Faggioli <dfaggioli@suse.com>
xen/common/sched/cpupool.c

index 476916c6ea46c76cef98a0a618de89fd9c4b45e8..b7721b5d02f414401967bea5081ee7daf3975d7b 100644 (file)
@@ -889,12 +889,10 @@ const cpumask_t *cpupool_valid_cpus(const struct cpupool *pool)
 
 void dump_runq(unsigned char key)
 {
-    unsigned long    flags;
     s_time_t         now = NOW();
     struct cpupool **c;
 
     spin_lock(&cpupool_lock);
-    local_irq_save(flags);
 
     printk("sched_smt_power_savings: %s\n",
             sched_smt_power_savings? "enabled":"disabled");
@@ -914,7 +912,6 @@ void dump_runq(unsigned char key)
         schedule_dump(*c);
     }
 
-    local_irq_restore(flags);
     spin_unlock(&cpupool_lock);
 }