]> xenbits.xensource.com Git - libvirt.git/commitdiff
rpc: avoid memory leak on error
authorEric Blake <eblake@redhat.com>
Mon, 4 Jul 2011 02:22:50 +0000 (10:22 +0800)
committerDaniel Veillard <veillard@redhat.com>
Mon, 4 Jul 2011 02:22:50 +0000 (10:22 +0800)
Detected by Coverity.  The leak is on an error path, but I'm not
sure whether that path is likely to be triggered in practice.

* src/rpc/virnetserverservice.c (virNetServerServiceAccept): Plug leak.

src/rpc/virnetserverservice.c

index e84f72c918529926a6b846dd7853b1218bce4667..8c250e246d05fed1ff8551add06f5a1515f2de74 100644 (file)
@@ -82,7 +82,12 @@ cleanup:
     return;
 
 error:
-    virNetSocketFree(clientsock);
+    if (client) {
+        virNetServerClientClose(client);
+        virNetServerClientFree(client);
+    } else {
+        virNetSocketFree(clientsock);
+    }
 }