]> xenbits.xensource.com Git - libvirt.git/commitdiff
tests: Don't call virNetServerClientClose without valid client
authorJohn Ferlan <jferlan@redhat.com>
Mon, 2 Apr 2018 11:19:38 +0000 (07:19 -0400)
committerJohn Ferlan <jferlan@redhat.com>
Thu, 19 Apr 2018 18:24:32 +0000 (14:24 -0400)
If @client hasn't been opened, then don't call virNetServerClientClose
since that'll cause certain failure.

Found by Coverity

Signed-off-by: John Ferlan <jferlan@redhat.com>
tests/virnetserverclienttest.c

index 398b46928cd7aa9b3e8f8d85ca929f83a8c58e37..aa3f0bcf9b780d0058e48076c2d0078f0153f31e 100644 (file)
@@ -152,7 +152,8 @@ static int testIdentity(const void *opaque ATTRIBUTE_UNUSED)
     ret = 0;
  cleanup:
     virObjectUnref(sock);
-    virNetServerClientClose(client);
+    if (!client)
+        virNetServerClientClose(client);
     virObjectUnref(client);
     virObjectUnref(ident);
     VIR_FORCE_CLOSE(sv[0]);