]> xenbits.xensource.com Git - libvirt.git/commitdiff
src: conditionalize use of O_BINARY
authorDaniel P. Berrangé <berrange@redhat.com>
Wed, 22 Jan 2020 11:48:05 +0000 (11:48 +0000)
committerDaniel P. Berrangé <berrange@redhat.com>
Wed, 29 Jan 2020 14:51:40 +0000 (14:51 +0000)
The O_BINARY flag is not defined on all platforms so we must
conditionalize its use once we remove GNULIB.

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
src/util/virfdstream.c

index a903107afbb4fe88a2c3bcb18d782761f492e04a..58b77aa6fafbe3070525de1bdd40a1e9b519938c 100644 (file)
@@ -1243,7 +1243,10 @@ virFDStreamOpenFileInternal(virStreamPtr st,
     VIR_DEBUG("st=%p path=%s oflags=0x%x offset=%llu length=%llu mode=0%o",
               st, path, oflags, offset, length, mode);
 
-    oflags |= O_NOCTTY | O_BINARY;
+    oflags |= O_NOCTTY;
+#ifdef O_BINARY
+    oflags |= O_BINARY;
+#endif
 
     if (oflags & O_CREAT)
         fd = open(path, oflags, mode);