]> xenbits.xensource.com Git - people/iwj/xen.git/commitdiff
Revert "xen/arm: domain_builder: irq sanity check logic fix"
authorAndrew Cooper <andrew.cooper3@citrix.com>
Wed, 29 Nov 2017 11:45:02 +0000 (11:45 +0000)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Wed, 29 Nov 2017 11:45:02 +0000 (11:45 +0000)
This reverts commit 11e7dd958de73a45645bd40d82280660bd2c9ee8.

It breaks boot on ARM.

Reported-by: Julien Grall <julien.grall@linaro.org>
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
xen/arch/arm/domain_build.c

index f50f8b9a2651fd91444c6486fec07b961fa420c7..c74f4dd69d6b9667ceba129a259ea1bbcaea7a80 100644 (file)
@@ -501,10 +501,9 @@ static void set_interrupt_ppi(gic_interrupt_t interrupt, unsigned int irq,
 {
     __be32 *cells = interrupt;
 
-    BUG_ON(irq < 16);
-    BUG_ON(irq >= 32);
+    BUG_ON(irq < 16 && irq >= 32);
 
-    /* See linux Documentation/devicetree/bindings/interrupt-controller/arm,gic.txt */
+    /* See linux Documentation/devictree/bindings/arm/gic.txt */
     dt_set_cell(&cells, 1, 1); /* is a PPI */
     dt_set_cell(&cells, 1, irq - 16); /* PPIs start at 16 */
     dt_set_cell(&cells, 1, (cpumask << 8) | level);