]> xenbits.xensource.com Git - people/aperard/qemu-dm.git/commitdiff
rust/hw/char/pl011: Extract DR write logic into separate function
authorRakesh Jeyasingh <rakeshjb010@gmail.com>
Mon, 7 Apr 2025 18:13:27 +0000 (23:43 +0530)
committerPaolo Bonzini <pbonzini@redhat.com>
Wed, 23 Apr 2025 08:35:23 +0000 (10:35 +0200)
- Split `write()` DR case into `write_data_register()`

Signed-off-by: Rakesh Jeyasingh <rakeshjb010@gmail.com>
Link: https://lore.kernel.org/r/20250407181327.171563-3-rakeshjb010@gmail.com
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
rust/hw/char/pl011/src/device.rs

index 87153cdae139477548086099214fc9beab1a12dc..bb2a0f207a5a11899815f3c87c989d928896d7dd 100644 (file)
@@ -221,12 +221,7 @@ impl PL011Registers {
         // eprintln!("write offset {offset} value {value}");
         use RegisterOffset::*;
         match offset {
-            DR => {
-                // interrupts always checked
-                let _ = self.loopback_tx(value.into());
-                self.int_level |= Interrupt::TX.0;
-                return true;
-            }
+            DR => return self.write_data_register(value),
             RSR => {
                 self.receive_status_error_clear = 0.into();
             }
@@ -307,6 +302,13 @@ impl PL011Registers {
         u32::from(c)
     }
 
+    fn write_data_register(&mut self, value: u32) -> bool {
+        // interrupts always checked
+        let _ = self.loopback_tx(value.into());
+        self.int_level |= Interrupt::TX.0;
+        true
+    }
+
     #[inline]
     #[must_use]
     fn loopback_tx(&mut self, value: registers::Data) -> bool {