]> xenbits.xensource.com Git - libvirt.git/commitdiff
test: drop redundant check
authorEric Blake <eblake@redhat.com>
Wed, 2 Nov 2011 17:53:33 +0000 (11:53 -0600)
committerEric Blake <eblake@redhat.com>
Wed, 2 Nov 2011 20:11:36 +0000 (14:11 -0600)
libvirt.c guarantees that nparams is non-zero for scheduler parameters.

* src/test/test_driver.c (testDomainGetSchedulerParamsFlags): Drop
redundant check.  Avoid strcpy.

src/test/test_driver.c

index 4e1973adb69164dfb764ddeb85d4056dcd4e05e5..3dbce1837699aec3bb4155d6ac88a1c7a70fa6fe 100644 (file)
@@ -2709,11 +2709,12 @@ testDomainGetSchedulerParamsFlags(virDomainPtr domain,
         goto cleanup;
     }
 
-    if (*nparams < 1) {
-        testError(VIR_ERR_INVALID_ARG, "%s", _("Invalid parameter count"));
+    if (virStrcpyStatic(params[0].field,
+                        VIR_DOMAIN_SCHEDULER_WEIGHT) == NULL) {
+        testError(VIR_ERR_INTERNAL_ERROR, _("Field name '%s' too long"),
+                  VIR_DOMAIN_SCHEDULER_WEIGHT);
         goto cleanup;
     }
-    strcpy(params[0].field, VIR_DOMAIN_SCHEDULER_WEIGHT);
     params[0].type = VIR_TYPED_PARAM_UINT;
     /* XXX */
     /*params[0].value.ui = privdom->weight;*/