]> xenbits.xensource.com Git - people/gdunlap/xsatool/commitdiff
repo: Add missing spaces in the configure cmdline for "xentools"
authorJulien Grall <jgrall@amazon.com>
Mon, 27 Jul 2020 16:04:15 +0000 (17:04 +0100)
committerGeorge Dunlap <george.dunlap@citrix.com>
Tue, 28 Jul 2020 10:11:05 +0000 (11:11 +0100)
The operator + will just concatenate two strings. As the result, the
configure cmdline for "xentools" will look like:

./configure --disable-stubdom --disable-qemu-traditional--with-system-qemu=/bin/false --with-system-seabios=/bin/false--disable-ovmf

This can be avoided by explicitely adding the spaces.

Signed-off-by: Julien Grall <jgrall@amazon.com>
Reviewed-by: George Dunlap <george.dunlap@citrix.com>
repo.go

diff --git a/repo.go b/repo.go
index 1e7802f8142c1f001c4921fcb9ea456c154ca5b8..f00b7469101f4c3f98c07a98734bb4761a6a58bf 100644 (file)
--- a/repo.go
+++ b/repo.go
@@ -139,8 +139,8 @@ func MainRepoInit(unused *XSAMeta, args []string) (ret int) {
        G.config.Tool.BuildSequences = map[string]BuildSequence{
                "simple": {"./configure", "make -j 8"},
                "xen":    {"make -j 8 xen"},
-               "xentools": {"./configure --disable-stubdom --disable-qemu-traditional" +
-                       "--with-system-qemu=/bin/false --with-system-seabios=/bin/false" +
+               "xentools": {"./configure --disable-stubdom --disable-qemu-traditional " +
+                       "--with-system-qemu=/bin/false --with-system-seabios=/bin/false " +
                        "--disable-ovmf",
                        "make -j 8"},
        }