]> xenbits.xensource.com Git - people/royger/xen.git/commitdiff
libxl: Set rc on failure of usbdev_busaddr_to_busid
authorIan Jackson <ian.jackson@eu.citrix.com>
Mon, 4 Apr 2016 14:18:03 +0000 (15:18 +0100)
committerIan Jackson <Ian.Jackson@eu.citrix.com>
Fri, 8 Apr 2016 13:33:56 +0000 (14:33 +0100)
We must set rc before using `goto out'.

Bug introduced in bf7628f0 "libxl: add pvusb API".

CID: 1358113
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
CC: coverity@xenproject.org
CC: Simon Cao <caobosimon@gmail.com>
CC: George Dunlap <george.dunlap@citrix.com>
Reviewed-by: Chunyan Liu <cyliu@suse.com>
tools/libxl/libxl_pvusb.c

index f69792a12c706a51e3fbeb5a0036e9d68d080abe..07030a4bc3410916f89f057ec05a1cb80d61e2fc 100644 (file)
@@ -964,6 +964,7 @@ static int libxl__device_usbdev_add_xenstore(libxl__gc *gc, uint32_t domid,
                                     usbdev->u.hostdev.hostaddr);
     if (!busid) {
         LOG(DEBUG, "Fail to get busid of usb device");
+        rc = ERROR_FAIL;
         goto out;
     }