]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: Add coverity[negative_returns] tag
authorJohn Ferlan <jferlan@redhat.com>
Tue, 22 Jan 2013 14:41:01 +0000 (09:41 -0500)
committerMichal Privoznik <mprivozn@redhat.com>
Tue, 22 Jan 2013 15:59:45 +0000 (16:59 +0100)
This avoids "Event negative_returns: A negative constant "-1" is passed as
an argument to a parameter that cannot be negative.".  The called function
uses -1 to determine whether it needs to traverse all the hostdevs.

src/qemu/qemu_hotplug.c

index 19172e1255e99629fe8c35b48912eea0c527cd15..81031833863933e358259eb4ba47a25ee90085c0 100644 (file)
@@ -2539,6 +2539,7 @@ qemuDomainDetachNetDevice(virQEMUDriverPtr driver,
     detach = vm->def->nets[detachidx];
 
     if (virDomainNetGetActualType(detach) == VIR_DOMAIN_NET_TYPE_HOSTDEV) {
+        /* coverity[negative_returns] */
         ret = qemuDomainDetachThisHostDevice(driver, vm,
                                              virDomainNetGetActualHostdev(detach),
                                              -1);