]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: command: Use correct type for switch in qemuBuildDiskDeviceStr
authorPeter Krempa <pkrempa@redhat.com>
Mon, 28 Jan 2019 14:46:41 +0000 (15:46 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Fri, 8 Feb 2019 07:34:26 +0000 (08:34 +0100)
Cast disk->bus to proper type and add missing values to the enum so it's
more obvious what types are supported.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
src/qemu/qemu_command.c

index 77018a2c4b6eb5033fe6a2e69a1c406378eac8e0..7c79223812ab5e481a7a7630115ff9f45cd13704 100644 (file)
@@ -1910,7 +1910,7 @@ qemuBuildDiskDeviceStr(const virDomainDef *def,
     if (disk->iothread && !qemuCheckIOThreads(def, disk))
         goto error;
 
-    switch (disk->bus) {
+    switch ((virDomainDiskBus) disk->bus) {
     case VIR_DOMAIN_DISK_BUS_IDE:
         if (disk->info.addr.drive.target != 0) {
             virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
@@ -2132,6 +2132,10 @@ qemuBuildDiskDeviceStr(const virDomainDef *def,
         virBufferAsprintf(&opt, "floppy,unit=%d", disk->info.addr.drive.unit);
         break;
 
+    case VIR_DOMAIN_DISK_BUS_XEN:
+    case VIR_DOMAIN_DISK_BUS_UML:
+    case VIR_DOMAIN_DISK_BUS_SD:
+    case VIR_DOMAIN_DISK_BUS_LAST:
     default:
         virReportError(VIR_ERR_INTERNAL_ERROR,
                        _("unsupported disk bus '%s' with device setup"), bus);