]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: backup: Properly delete temporary bitmap after push-mode incremental backup
authorPeter Krempa <pkrempa@redhat.com>
Tue, 5 Jan 2021 14:43:21 +0000 (15:43 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Wed, 6 Jan 2021 08:25:12 +0000 (09:25 +0100)
Refactor in 0316c28a453ac used incorrect source variable to initialize
the variable which holds the name of the bitmap which needs to be
deleted after the backup job finishes. This resulted into deleting the
source bitmap of the backup rather than the temporary one.

Use 'dd->incrementalBitmap' which holds the temporary bitmap name
instead of 'dd->backupdisk->incremental' which holds the name of the
source bitmap which is used by the backup.

Fixes: 0316c28a453ac15f58c61f30359f66ab9a649884
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1908647
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_backup.c

index b2340eb1cf12c195f4fd55d38121cb29e63bb394..c444f8aaba8d939961f1ecf11cf3407d505536fd 100644 (file)
@@ -235,7 +235,7 @@ qemuBackupDiskPrepareOneBitmaps(struct qemuBackupDiskData *dd,
                                                  blockNamedNodeData) < 0)
             return -1;
 
-        dd->domdiskIncrementalBitmap = dd->backupdisk->incremental;
+        dd->domdiskIncrementalBitmap = dd->incrementalBitmap;
     }
 
     return 0;