]> xenbits.xensource.com Git - people/liuw/libxenctrl-split/libvirt.git/commitdiff
storage: Remove duplicitous refreshVol in Sheepdog buildVol
authorJohn Ferlan <jferlan@redhat.com>
Thu, 8 Oct 2015 17:35:01 +0000 (13:35 -0400)
committerJohn Ferlan <jferlan@redhat.com>
Tue, 13 Oct 2015 22:03:55 +0000 (18:03 -0400)
As of commit id '155ca616' a 'refreshVol' is called after a buildVol
succeeds in storageVolCreateXML, thus a volStorageBackendSheepdogRefreshVolInfo
call in virStorageBackendSheepdogBuildVol is no longer necessary.

Additionally, the 'conn' parameter becomes unused.

Signed-off-by: John Ferlan <jferlan@redhat.com>
src/storage/storage_backend_sheepdog.c

index 69ba78361447150456b492a91e6b0d1850d824a4..12008139112ae7fbfd34dbc8f48d24307a5b934a 100644 (file)
@@ -257,7 +257,7 @@ virStorageBackendSheepdogCreateVol(virConnectPtr conn ATTRIBUTE_UNUSED,
 
 
 static int
-virStorageBackendSheepdogBuildVol(virConnectPtr conn,
+virStorageBackendSheepdogBuildVol(virConnectPtr conn ATTRIBUTE_UNUSED,
                                   virStoragePoolObjPtr pool,
                                   virStorageVolDefPtr vol,
                                   unsigned int flags)
@@ -279,9 +279,6 @@ virStorageBackendSheepdogBuildVol(virConnectPtr conn,
     if (virCommandRun(cmd, NULL) < 0)
         goto cleanup;
 
-    if (virStorageBackendSheepdogRefreshVol(conn, pool, vol) < 0)
-        goto cleanup;
-
     ret = 0;
  cleanup:
     virCommandFree(cmd);