virPCIGetNetName: Initialize @netname to NULL

This is a return argument that is to be compared against NULL on
successful return. However, it is not initialized and therefore
relies on callers setting it to NULL prior calling the function.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>

diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c
index 92ef008ca12ee8e69da1c521e3b1ea2e885d34d3..f3e3d442ed0bbccdb9fd5260fbad4de98db86cdf 100644 (file)
--- a/src/util/virnetdev.c
+++ b/src/util/virnetdev.c
@@ -1445,8 +1445,6 @@ virNetDevGetVirtualFunctionInfo(const char *vfname, char **pfname,
 {
     int ret = -1;
 
-    *pfname = NULL;
-
     if (virNetDevGetPhysicalFunction(vfname, pfname) < 0)
         return -1;
 

diff --git a/src/util/virpci.c b/src/util/virpci.c
index 537876bcba2635bba81cba58704a07cd6016c492..ef578bf77473b3d96886d5d983ecb1290f35cdc3 100644 (file)
--- a/src/util/virpci.c
+++ b/src/util/virpci.c
@@ -2853,6 +2853,8 @@ virPCIGetNetName(const char *device_link_sysfs_path,
     struct dirent *entry = NULL;
     size_t i = 0;
 
+    *netname = NULL;
+
     if (virBuildPath(&pcidev_sysfs_net_path, device_link_sysfs_path,
                      "net") == -1) {
         virReportOOMError();