]> xenbits.xensource.com Git - libvirt.git/commitdiff
nwfilter: Fix return value comparison for virNWFilterTriggerVMFilterRebuild
authorJohn Ferlan <jferlan@redhat.com>
Thu, 25 May 2017 13:35:58 +0000 (09:35 -0400)
committerJohn Ferlan <jferlan@redhat.com>
Sat, 15 Jul 2017 18:45:46 +0000 (14:45 -0400)
Should compare < 0 to be correct.

Signed-off-by: John Ferlan <jferlan@redhat.com>
src/conf/virnwfilterobj.c

index b5aaa6b0d485003fbf9adb5eff14df88b60cd5bd..0027d45b61924fb6c2ee07b9ce0ec6ee5275ca8c 100644 (file)
@@ -253,7 +253,7 @@ virNWFilterObjTestUnassignDef(virNWFilterObjPtr obj)
 
     obj->wantRemoved = true;
     /* trigger the update on VMs referencing the filter */
-    if (virNWFilterTriggerVMFilterRebuild())
+    if (virNWFilterTriggerVMFilterRebuild() < 0)
         rc = -1;
 
     obj->wantRemoved = false;
@@ -345,7 +345,7 @@ virNWFilterObjListAssignDef(virNWFilterObjListPtr nwfilters,
 
         obj->newDef = def;
         /* trigger the update on VMs referencing the filter */
-        if (virNWFilterTriggerVMFilterRebuild()) {
+        if (virNWFilterTriggerVMFilterRebuild() < 0) {
             obj->newDef = NULL;
             virNWFilterObjUnlock(obj);
             return NULL;