]> xenbits.xensource.com Git - libvirt.git/commitdiff
Avoid crash when LXC start fails with no interface target
authorDaniel P. Berrange <berrange@redhat.com>
Fri, 23 Nov 2012 16:36:52 +0000 (16:36 +0000)
committerDaniel P. Berrange <berrange@redhat.com>
Tue, 27 Nov 2012 17:02:22 +0000 (17:02 +0000)
If the <interface> device did not contain any <target>
element, LXC would crash on a NULL pointer if starting
the container failed

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
src/lxc/lxc_process.c

index d489c048578c65553e2b36a23b7c4ea0fbf25ca6..954cb9e962257d6b4cac4fe0fc0ddd2dac4d68bd 100644 (file)
@@ -254,7 +254,8 @@ static void virLXCProcessCleanup(virLXCDriverPtr driver,
     for (i = 0 ; i < vm->def->nnets ; i++) {
         virDomainNetDefPtr iface = vm->def->nets[i];
         vport = virDomainNetGetActualVirtPortProfile(iface);
-        ignore_value(virNetDevSetOnline(iface->ifname, false));
+        if (iface->ifname)
+            ignore_value(virNetDevSetOnline(iface->ifname, false));
         if (vport && vport->virtPortType == VIR_NETDEV_VPORT_PROFILE_OPENVSWITCH)
             ignore_value(virNetDevOpenvswitchRemovePort(
                             virDomainNetGetActualBridgeName(iface),