remote: Improve daemon startup error reporting

If I toggle enable_tcp in libvirtd.conf and add --listen in
/etc/init.d/libvirtd, I get the unhelpful error:

Starting libvirtd daemon: error: Unable to initialize network sockets.

Running without --daemon provides much more useful info:

sudo libvirtd --listen
11:29:26.117: error : remoteCheckCertFile:270 : Cannot access CA certificate '/etc/pki/CA/cacert.pem': No such file or directory

The daemon architecture makes it difficult to report this useful
info if daemonized, so point users to /var/log/messages and
dropping the --daemon flag if they want more info.

diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c
index fefa7aa01f774b3c8a8887856ba0d59d16b2abf6..cee6f13888dfde1977ddc63f809bff12a06b7e76 100644 (file)
--- a/daemon/libvirtd.c
+++ b/daemon/libvirtd.c
@@ -474,7 +474,10 @@ static int daemonForkIntoBackground(void) {
                 goto again;
 
             if (ret == 1 && status != 0) {
-                fprintf(stderr, "error: %s\n", virDaemonErrTypeToString(status));
+                fprintf(stderr,
+                        "error: %s. Check /var/log/messages or run without "
+                        "--daemon for more info.\n",
+                        virDaemonErrTypeToString(status));
             }
             _exit(ret == 1 && status == 0 ? 0 : 1);
         }