]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: fix use after free
authorEric Blake <eblake@redhat.com>
Tue, 31 Jul 2012 14:05:14 +0000 (08:05 -0600)
committerEric Blake <eblake@redhat.com>
Tue, 31 Jul 2012 14:10:59 +0000 (08:10 -0600)
Detected by Coverity.

* src/qemu/qemu_hotplug.c (qemuDomainAttachHostDevice): Avoid
double free of usb on failure.

src/qemu/qemu_hotplug.c

index ba841e92697ca743229bdee43a7352c53dbf6369..ceffe22846f0dce9a69963183a6a4d5071f139e2 100644 (file)
@@ -1170,6 +1170,7 @@ int qemuDomainAttachHostDevice(struct qemud_driver *driver,
 
         if (usbDeviceListAdd(list, usb) < 0) {
             usbFreeDevice(usb);
+            usb = NULL:
             goto cleanup;
         }