]> xenbits.xensource.com Git - people/liuw/libxenctrl-split/libvirt.git/commitdiff
util: command: Deduplicate code in virCommandNewArgList
authorPeter Krempa <pkrempa@redhat.com>
Wed, 22 Apr 2015 08:07:00 +0000 (10:07 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Wed, 22 Apr 2015 12:05:50 +0000 (14:05 +0200)
virCommandNewArgList can use virCommandNewVAList.

src/util/vircommand.c

index 648f5ed65445c031b2ef1824f9de49fedcb6f189..c41bd7f69761362ca3ea580b932ce2d63c131a43 100644 (file)
@@ -919,17 +919,13 @@ virCommandNewArgs(const char *const*args)
 virCommandPtr
 virCommandNewArgList(const char *binary, ...)
 {
-    virCommandPtr cmd = virCommandNew(binary);
+    virCommandPtr cmd;
     va_list list;
-    const char *arg;
-
-    if (!cmd || cmd->has_error)
-        return cmd;
 
     va_start(list, binary);
-    while ((arg = va_arg(list, const char *)) != NULL)
-        virCommandAddArg(cmd, arg);
+    cmd = virCommandNewVAList(binary, list);
     va_end(list);
+
     return cmd;
 }