]> xenbits.xensource.com Git - pvdrivers/win/xenbus.git/commitdiff
Further VS2013 SDV fixes
authorPaul Durrant <paul.durrant@citrix.com>
Mon, 2 Mar 2015 15:52:07 +0000 (15:52 +0000)
committerPaul Durrant <paul.durrant@citrix.com>
Mon, 2 Mar 2015 15:52:07 +0000 (15:52 +0000)
The last set of fixes was not complete. SDV failed again, later on, in
building xenbus.sys.

Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
src/xenbus/bus.c
src/xenbus/fdo.c

index bf0bec7914754b54ff3c4d65cb3acc88095117d2..1cd527f6c74b5becb828305ea819d7f5d37e7338 100644 (file)
@@ -122,8 +122,10 @@ BusGetDmaAdapter(
 
     if (Context->InterceptDmaAdapter != 0) {
         RTL_OSVERSIONINFOEXW    VersionInformation;
+        NTSTATUS                status;
 
-        RtlGetVersion((PRTL_OSVERSIONINFOW)&VersionInformation);
+        status = RtlGetVersion((PRTL_OSVERSIONINFOW)&VersionInformation);
+        ASSERT(NT_SUCCESS(status));
 
         if (VersionInformation.dwMajorVersion == 6 &&
             VersionInformation.dwMinorVersion == 0) {
index 76cac4f356093b908404efeb3a360552c2f2235e..17a74ab1b8ef43cb7d3f92b11cb0df6f604ca70f 100644 (file)
@@ -1822,6 +1822,7 @@ FdoConnectInterrupt(
     )
 {
     IO_CONNECT_INTERRUPT_PARAMETERS     Connect;
+    BOOLEAN                             Found;
     ULONG                               Cpu;
     NTSTATUS                            status;
 
@@ -1869,12 +1870,13 @@ FdoConnectInterrupt(
     (*Interrupt)->Vector = (UCHAR)Connect.FullySpecified.Vector;
 
 #if defined(__i386__)
-    (VOID)_BitScanReverse(&Cpu, Connect.FullySpecified.ProcessorEnableMask);
+    Found = _BitScanReverse(&Cpu, Connect.FullySpecified.ProcessorEnableMask);
 #elif defined(__x86_64__)
-    (VOID)_BitScanReverse64(&Cpu, Connect.FullySpecified.ProcessorEnableMask);
+    Found = _BitScanReverse64(&Cpu, Connect.FullySpecified.ProcessorEnableMask);
 #else
 #error 'Unrecognised architecture'
 #endif
+    ASSERT(Found);
 
     (*Interrupt)->Cpu = Cpu;