]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemuBuildShmemCommandLine: use VIR_AUTOFREE for devstr
authorJán Tomko <jtomko@redhat.com>
Tue, 20 Aug 2019 11:25:24 +0000 (13:25 +0200)
committerJán Tomko <jtomko@redhat.com>
Mon, 26 Aug 2019 20:16:06 +0000 (22:16 +0200)
Now that it's only used once.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/qemu/qemu_command.c

index 49984748c8b4982df372f2040ea6ef1fec1a18bc..993c6000216e7436fcd20b7888eaadef1b4cadf7 100644 (file)
@@ -9144,7 +9144,7 @@ qemuBuildShmemCommandLine(virLogManagerPtr logManager,
 {
     VIR_AUTOPTR(virJSONValue) memProps = NULL;
     VIR_AUTOCLEAN(virBuffer) buf = VIR_BUFFER_INITIALIZER;
-    char *devstr = NULL;
+    VIR_AUTOFREE(char *) devstr = NULL;
     VIR_AUTOFREE(char *) chardev = NULL;
     int rc;
     unsigned int cdevflags = QEMU_BUILD_CHARDEV_TCP_NOWAIT |
@@ -9207,13 +9207,10 @@ qemuBuildShmemCommandLine(virLogManagerPtr logManager,
     if (!devstr)
         return -1;
 
-    if (qemuCommandAddExtDevice(cmd, &shmem->info) < 0) {
-        VIR_FREE(devstr);
+    if (qemuCommandAddExtDevice(cmd, &shmem->info) < 0)
         return -1;
-    }
 
     virCommandAddArgList(cmd, "-device", devstr, NULL);
-    VIR_FREE(devstr);
 
     if (shmem->server.enabled) {
         chardev = qemuBuildChrChardevStr(logManager, secManager,