]> xenbits.xensource.com Git - people/liuw/libxenctrl-split/libvirt.git/commitdiff
security_dac: check if virSecurityDACGetIds returns negative
authorJán Tomko <jtomko@redhat.com>
Fri, 20 Nov 2015 07:26:00 +0000 (08:26 +0100)
committerJán Tomko <jtomko@redhat.com>
Wed, 9 Dec 2015 09:44:26 +0000 (10:44 +0100)
Use the customary check '< 0' instead of checking for non-zero.

No functional change.

src/security/security_dac.c

index cdde34ec2d8b7c7c5629e0400bbfe9884a082869..6cb483949bde2093ab9371e57e896bc16d799225 100644 (file)
@@ -547,7 +547,7 @@ virSecurityDACSetSecurityHostdevLabelHelper(const char *file,
     uid_t user;
     gid_t group;
 
-    if (virSecurityDACGetIds(secdef, priv, &user, &group, NULL, NULL))
+    if (virSecurityDACGetIds(secdef, priv, &user, &group, NULL, NULL) < 0)
         return -1;
 
     return virSecurityDACSetOwnership(priv, NULL, file, user, group);
@@ -1305,7 +1305,7 @@ virSecurityDACSetChildProcessLabel(virSecurityManagerPtr mgr,
 
     secdef = virDomainDefGetSecurityLabelDef(def, SECURITY_DAC_NAME);
 
-    if (virSecurityDACGetIds(secdef, priv, &user, &group, NULL, NULL))
+    if (virSecurityDACGetIds(secdef, priv, &user, &group, NULL, NULL) < 0)
         return -1;
 
     VIR_DEBUG("Setting child to drop privileges to %u:%u",