]> xenbits.xensource.com Git - people/liuw/libxenctrl-split/libvirt.git/commitdiff
Add missing 'goto error' in QEMU command line building
authorDaniel P. Berrange <berrange@redhat.com>
Tue, 11 Sep 2012 13:44:40 +0000 (14:44 +0100)
committerDaniel P. Berrange <berrange@redhat.com>
Fri, 14 Sep 2012 16:15:43 +0000 (17:15 +0100)
If reporting case of a binary not supporting KVM or kQEMU, libvirt
forgot to jump to the error branch for cleanup

src/qemu/qemu_command.c

index b8c5658f5aa406b018f1d4a55f1692712659433a..a512e6adab14b772b0433e93897d338665620aee 100644 (file)
@@ -4449,6 +4449,7 @@ qemuBuildCommandLine(virConnectPtr conn,
             virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                            _("the QEMU binary %s does not support kqemu"),
                            emulator);
+            goto error;
         }
         break;
 
@@ -4462,6 +4463,7 @@ qemuBuildCommandLine(virConnectPtr conn,
             virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                            _("the QEMU binary %s does not support kvm"),
                            emulator);
+            goto error;
         }
         break;