]> xenbits.xensource.com Git - libvirt.git/commitdiff
Revert "lxc_fuse: Tell FUSE that /proc/meminfo is nonseekable"
authorMichal Privoznik <mprivozn@redhat.com>
Thu, 29 Jun 2023 06:46:04 +0000 (08:46 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Thu, 29 Jun 2023 13:21:00 +0000 (15:21 +0200)
After v8.1.0-61-g030faee28d it is no longer necessary to make the
/proc/meminfo file nonseekable as our code that fills the file
with spoofed values can handle seeking just fine.

Previously, `free(1)` was okay with failed lseek(), but this was
ages ago and meanwhile the procps project moved to creating a
library and moved the file parsing code under an exported
function. In attempt to make the function callable multiple
times, it can lseek() multiple times and failure to do so is
fatal.

This reverts commit 766495508650bebd5f4ac23224ecd0a2ee2ca9eb

Resolves: https://gitlab.com/libvirt/libvirt/-/issues/492
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/lxc/lxc_fuse.c

index a11cbbaff79d464cf856aa7ca9aae6bca5bfa7bc..44bdd1412df6ffc4497a2388f7b82093161556b2 100644 (file)
@@ -163,7 +163,6 @@ lxcProcOpen(const char *path,
         return -EACCES;
 
     fi->direct_io = 1;
-    fi->nonseekable = 1;
     return 0;
 }