]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemuBlockJobDataDisposeJobdata: Free data.commit.disabledBitmapsBase
authorMichal Privoznik <mprivozn@redhat.com>
Thu, 14 May 2020 09:26:22 +0000 (11:26 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Thu, 14 May 2020 09:45:29 +0000 (11:45 +0200)
==179663== 35 (24 direct, 11 indirect) bytes in 1 blocks are definitely lost in loss record 205 of 461
==179663==    at 0x4839EC6: calloc (vg_replace_malloc.c:762)
==179663==    by 0x5791AC0: g_malloc0 (in /usr/lib64/libglib-2.0.so.0.6400.1)
==179663==    by 0x190C79: qemuDomainObjPrivateXMLParseBlockjobDataCommit (qemu_domain.c:3295)
==179663==    by 0x190DF7: qemuDomainObjPrivateXMLParseBlockjobDataSpecific (qemu_domain.c:3331)
==179663==    by 0x19157D: qemuDomainObjPrivateXMLParseBlockjobData (qemu_domain.c:3469)
==179663==    by 0x1918E8: qemuDomainObjPrivateXMLParseBlockjobs (qemu_domain.c:3498)
==179663==    by 0x193841: qemuDomainObjPrivateXMLParse (qemu_domain.c:3944)
==179663==    by 0x4A1BA9D: virDomainObjParseXML (domain_conf.c:22306)
==179663==    by 0x4A1BFE9: virDomainObjParseNode (domain_conf.c:22429)
==179663==    by 0x4A1C0B4: virDomainObjParseFile (domain_conf.c:22443)
==179663==    by 0x1431E1: testCompareStatusXMLToXMLFiles (qemuxml2xmltest.c:61)
==179663==    by 0x177722: virTestRun (testutils.c:142)

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
src/qemu/qemu_blockjob.c

index e51499532ff545aec2eef56c1ba11a9353daab2c..17dc08476b36a5df118303c444a0a190a05beec6 100644 (file)
@@ -84,6 +84,11 @@ qemuBlockJobDataDisposeJobdata(qemuBlockJobDataPtr job)
         virObjectUnref(job->data.backup.store);
         g_free(job->data.backup.bitmap);
     }
+
+    if (job->type == QEMU_BLOCKJOB_TYPE_COMMIT ||
+        job->type == QEMU_BLOCKJOB_TYPE_ACTIVE_COMMIT) {
+        virStringListFree(job->data.commit.disabledBitmapsBase);
+    }
 }