]> xenbits.xensource.com Git - people/royger/xen.git/commitdiff
xen/arm: ffa: fix guest map RX/TX error code
authorJens Wiklander <jens.wiklander@linaro.org>
Mon, 4 Sep 2023 14:58:14 +0000 (16:58 +0200)
committerStefano Stabellini <stefano.stabellini@amd.com>
Thu, 7 Sep 2023 00:36:50 +0000 (17:36 -0700)
FFA_RXTX_MAP is currently limited to mapping only one 4k page for each
RX and TX buffer. If a guest tries to map more than one page, an error
is returned. Until this patch, we have been using FFA_RET_NOT_SUPPORTED.
However, that error code is reserved in the FF-A specification to report
that the function is not implemented. Of all the other defined error
codes, the least bad is FFA_RET_INVALID_PARAMETERS, so use that instead.

Fixes: 38d81e7ccb11 ("xen/arm: ffa: support mapping guest RX/TX buffers")
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
xen/arch/arm/tee/ffa.c

index 802b2dbb1d36a59620949e369322fcafd4962a07..183528d133880aca1c17311cd1576f7fad24c65c 100644 (file)
@@ -706,7 +706,7 @@ static uint32_t handle_rxtx_map(uint32_t fid, register_t tx_addr,
     {
         printk(XENLOG_ERR "ffa: RXTX_MAP: error: %u pages requested (limit %u)\n",
                page_count, FFA_MAX_RXTX_PAGE_COUNT);
-        return FFA_RET_NOT_SUPPORTED;
+        return FFA_RET_INVALID_PARAMETERS;
     }
 
     /* Already mapped */