]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: caps: Don't try to ask for CAP_DAC_OVERRIDE if non-root
authorPeter Krempa <pkrempa@redhat.com>
Mon, 4 Feb 2019 15:24:15 +0000 (16:24 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Tue, 5 Feb 2019 07:57:35 +0000 (08:57 +0100)
It will not work. This breaks qemu capabilities probing as a user.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
src/qemu/qemu_capabilities.c

index 7ed5f94803af21349a6a1a55616b1ac5b35285b7..81ef0357e7bf6cda420d766a670e00811dad436a 100644 (file)
@@ -4524,7 +4524,8 @@ virQEMUCapsInitQMPCommandRun(virQEMUCapsInitQMPCommandPtr cmd,
 #if WITH_CAPNG
     /* QEMU might run into permission issues, e.g. /dev/sev (0600), override
      * them just for the purpose of probing */
-    virCommandAllowCap(cmd->cmd, CAP_DAC_OVERRIDE);
+    if (geteuid() == 0)
+        virCommandAllowCap(cmd->cmd, CAP_DAC_OVERRIDE);
 #endif
 
     virCommandSetGID(cmd->cmd, cmd->runGid);