]> xenbits.xensource.com Git - libvirt.git/commitdiff
src: Document autostart for session demon
authorMichal Privoznik <mprivozn@redhat.com>
Mon, 17 Dec 2018 13:42:51 +0000 (14:42 +0100)
committerMichal Privoznik <mprivozn@redhat.com>
Mon, 17 Dec 2018 17:27:32 +0000 (18:27 +0100)
The autostart under session daemon might not behave as you'd
expect it to behave. This patch is inspired by latest
libvirt-users discussion:

https://www.redhat.com/archives/libvirt-users/2018-December/msg00047.html

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
src/libvirt-domain.c

index d49d7f869f363d891e5c0418d186ec620ea83079..75c9014c0ecdff3a1f4fc99e7bd18748e743fe61 100644 (file)
@@ -6693,6 +6693,11 @@ virDomainCreateWithFiles(virDomainPtr domain, unsigned int nfiles,
  * configured to be automatically started when the host
  * machine boots.
  *
+ * Please note that this might result in unexpected behaviour if
+ * used for some session URIs. Since the session daemon is started
+ * with --timeout it comes and goes and as it does so it
+ * autostarts domains which might have been shut off recently.
+ *
  * Returns -1 in case of error, 0 in case of success
  */
 int