]> xenbits.xensource.com Git - people/tklengyel/xen.git/commitdiff
x86/dmop: Properly fail for PV guests
authorAndrew Cooper <andrew.cooper3@citrix.com>
Thu, 25 Feb 2021 16:54:17 +0000 (16:54 +0000)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Fri, 26 Feb 2021 12:28:52 +0000 (12:28 +0000)
The current code has an early exit for PV guests, but it returns 0 having done
nothing.

Fixes: 524a98c2ac5 ("public / x86: introduce __HYPERCALL_dm_op...")
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Ian Jackson <iwj@xenproject.org>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
Release-Acked-by: Ian Jackson <iwj@xenproject.org>
xen/arch/x86/hvm/dm.c

index 5bc172a5d4d38a4ce2f52b786f5a4180b5a548f1..612749442e41cdd60a9365b259d42e4d829d08b2 100644 (file)
@@ -365,6 +365,7 @@ int dm_op(const struct dmop_args *op_args)
     if ( rc )
         return rc;
 
+    rc = -EINVAL;
     if ( !is_hvm_domain(d) )
         goto out;