test: Use virDomainObjListFindByIDRef

Rather than using virDomainObjListFindByID, let's be more consistent
and return a reffed and locked object. Since we're using the Ref API,
use virDomainObjEndAPI on @dom and not just virObjectUnlock.

Signed-off-by: John Ferlan <jferlan@redhat.com>
Reviewed-by: Marc Hartmayer <mhartmay@linux.vnet.ibm.com>

diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index 0bfc7974005dd6bffffefd3c3b104f490d7e67d8..5e39ae574c914a31e1b5fce40be6f35a75c731f1 100644 (file)
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
@@ -1720,16 +1720,14 @@ static virDomainPtr testDomainLookupByID(virConnectPtr conn,
     virDomainPtr ret = NULL;
     virDomainObjPtr dom;
 
-    if (!(dom = virDomainObjListFindByID(privconn->domains, id))) {
+    if (!(dom = virDomainObjListFindByIDRef(privconn->domains, id))) {
         virReportError(VIR_ERR_NO_DOMAIN, NULL);
-        goto cleanup;
+        return NULL;
     }
 
     ret = virGetDomain(conn, dom->def->name, dom->def->uuid, dom->def->id);
 
- cleanup:
-    if (dom)
-        virObjectUnlock(dom);
+    virDomainObjEndAPI(&dom);
     return ret;
 }